Copy TapAndPanGestureRecognizer from TextField #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
1 task
1 task
EchoEllet
reviewed
Dec 11, 2024
Comment on lines
+911
to
+917
| case TargetPlatform.linux: | ||
| // From observation, these platform's reset their tap count to 0 when | ||
| // the number of consecutive taps exceeds 3. For example on Debian Linux | ||
| // with GTK, when going past a triple click, on the fourth click the | ||
| // selection is moved to the precise click position, on the fifth click | ||
| // the word at the position is selected, and on the sixth click the | ||
| // paragraph at the position is selected. |
There was a problem hiding this comment.
Are those comments part of the original code?
EchoEllet
reviewed
Dec 11, 2024
Comment on lines
+263
to
+282
| final isShiftPressedValid = | ||
| _isShiftPressed && renderEditor?.selection.baseOffset != null; | ||
| switch (defaultTargetPlatform) { | ||
| case TargetPlatform.android: | ||
| case TargetPlatform.fuchsia: | ||
| editor?.hideToolbar(false); | ||
| case TargetPlatform.iOS: | ||
| // On mobile platforms the selection is set on tap up. | ||
| break; | ||
| case TargetPlatform.macOS: | ||
| editor?.hideToolbar(); | ||
| // On macOS, a shift-tapped unfocused field expands from 0, not from the | ||
| // previous selection. | ||
| if (isShiftPressedValid) { | ||
| final fromSelection = renderEditor?.hasFocus == true | ||
| ? null | ||
| : const TextSelection.collapsed(offset: 0); | ||
| _expandSelection( | ||
| details.globalPosition, SelectionChangedCause.tap, fromSelection); | ||
| return; |
There was a problem hiding this comment.
I don't know what any of this code does in this file but it seems well-written, consistent, and clean with good documentation and in Flutter repo style, copying code directly without explaining the changes is not very encouraged. Unfortunately, I have to revert.
EchoEllet
reviewed
Dec 11, 2024
Comment on lines
+453
to
+465
| // Q: why ? | ||
| // A: cannot access QuillRawEditorState.updateFloatingCursor | ||
| // | ||
| // if (defaultTargetPlatform == TargetPlatform.iOS && | ||
| // delegate.selectionEnabled && | ||
| // editor?.textEditingValue.selection.isCollapsed == true) { | ||
| // // Update the floating cursor. | ||
| // final cursorPoint = | ||
| // RawFloatingCursorPoint(state: FloatingCursorDragState.End); | ||
| // // !.updateFloatingCursor(cursorPoint); | ||
| // (editor as QuillRawEditorState?)?.updateFloatingCursor(cursorPoint); | ||
| // } | ||
| } |
There was a problem hiding this comment.
What is the question? We usually don't leave comments like way.
EchoEllet
added a commit
that referenced
this pull request
Dec 11, 2024
This reverts commit 2937dc8.
This was referenced Dec 11, 2024
Merged
EchoEllet
added a commit
that referenced
this pull request
Jan 18, 2025
This reverts commit 2937dc8.
1 task
EchoEllet
added a commit
that referenced
this pull request
Jan 19, 2025
* revert: mobile magnifier feature (#2026) This reverts commit af691e6. * revert: Copying TapAndPanGestureRecognizer from TextField (#2128) This reverts commit 2937dc8. * docs(migration): document removal of magnifier * chore: remove magnifierConfiguration from QuillEditorConfig * docs(changelog): reflect the change * chore: remove unused _replaceText() from raw_editor_state.dart as it is in editor_keyboard_shortcut_actions_manager.dart and added back due to git revert * chore: update onTapDown and onTapUp, document the revert in CHANGELOG.md and in the migration guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Fix #2124
Type of Change
Suggestions