Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Link selection and editing #2114

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Conversation

AtlasAutocode
Copy link
Collaborator

Description

Fix assertion when link text shortened in dialog and text of link had been selected.
Prevent link attribute extending over new line.
collectStyles when selection includes blank line.

Related Issues

Type of Change

  • New feature: Adds new functionality without breaking existing features.
  • [ X ] 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • [ X ] 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

@singerdmx singerdmx merged commit 56d7d48 into singerdmx:master Aug 15, 2024
2 checks passed
@AtlasAutocode AtlasAutocode deleted the collect branch September 2, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link editing error: "type 'Null' is not a subtype of type 'Block' in type cast"
2 participants