Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style settings #1962

Merged
merged 11 commits into from
Jun 30, 2024
Merged

Fix style settings #1962

merged 11 commits into from
Jun 30, 2024

Conversation

AtlasAutocode
Copy link
Collaborator

Description

Fixed issue 1951: style settings lost when press Enter twice. Add tests for document collectStyle.
Fixed: inline styles lost when using keyboard shortcut to create a list ('1.' and space => ordered list). This did not occur when using the toolbar button.
Fixed: example code custom style for header1: header text was invisible because color was not being set.

Related Issues

Additional notes

Current implementation uses 'double Enter key' to automatically exit block attributes such as list.
I was surprised that this also applies to align and indent.

Checklist

  • [ X ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ X ] I titled the PR using Conventional Commits.
  • [ X ] I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • [ X ] All existing and new tests are passing.
  • [ X ] I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • [ X ] No, this is not a breaking change.

@singerdmx singerdmx merged commit 858d61a into singerdmx:master Jun 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All font settings and styles are lost when you press Enter twice
2 participants