Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaking the example #1530

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Conversation

EchoEllet
Copy link
Collaborator

The first steps of remaking the example

This pull request is not ready yet

@EchoEllet EchoEllet marked this pull request as ready for review November 14, 2023 18:17
@EchoEllet EchoEllet merged commit 2e4ee8b into singerdmx:master Nov 14, 2023
1 check passed
@Alspb
Copy link
Collaborator

Alspb commented Jul 13, 2024

In this PR home_page.dart file was removed, which contained a triple tap for paragraph selection implementation (see #468, #1318, #1758), PR #983.
Sure, putting a fix into an example file is not a quite correct approach.
@EchoEllet, could you please take a look whether this triple tap functionality might be resurrected?

@EchoEllet
Copy link
Collaborator Author

In this PR home_page.dart file was removed, which contained a triple tap for paragraph selection implementation (see #468, #1318, #1758), PR #983.

I removed it in addition to the image and video embeds for the web because it wasn't quite implemented. The docs say the web is supported. Only for the example, though, you will get a runtime exception due to missing embeds in the production app.

The implementation in the extensions package was missing some things that are only implemented in the example.

I think we need to recreate the example once again. It could use a lot of improvements as I made it very quickly at the time of this PR, though this shouldn't be a high priority issue.

Regarding the mentioned issue, I'm not quite familiar with it.

@EchoEllet EchoEllet deleted the remake-the-example branch September 21, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants