Updated schema.json files for streams #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates JSON schema definitions for various Trello streams by replacing empty placeholder schemas with complete property definitions. The schemas now include detailed type specifications, nullable fields, and proper formatting for datetime fields.
Key changes:
- Added comprehensive JSON schemas for 10 Trello stream endpoints
- Defined properties with appropriate types (string, object, array, boolean, integer)
- Included date-time format specifications for temporal fields
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tap_trello/schemas/organizations.json | Defined schema for organization entities with preferences, memberships, and boards |
| tap_trello/schemas/organization_memberships.json | Added schema for organization membership records with status fields |
| tap_trello/schemas/organization_members.json | Created extensive member schema including preferences, limits, and profile data |
| tap_trello/schemas/organization_actions.json | Defined action schema with nested display entities and reaction limits |
| tap_trello/schemas/members.json | Added complete member schema with authentication, preferences, and board associations |
| tap_trello/schemas/card_custom_field_items.json | Defined schema for custom field items on cards |
| tap_trello/schemas/card_attachments.json | Added attachment schema with preview and metadata fields |
| tap_trello/schemas/board_memberships.json | Created board membership schema with member type and status |
| tap_trello/schemas/board_labels.json | Defined label schema with color and usage tracking |
| tap_trello/schemas/board_custom_fields.json | Added custom field schema with options and display configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vishalp-dev
reviewed
Dec 30, 2025
vishalp-dev
reviewed
Dec 30, 2025
| { | ||
| "type": "object", | ||
| "properties": { | ||
| "id": { |
sgandhi1311
reviewed
Jan 1, 2026
| --- | ||
| Copyright © 2020 Stitch | ||
| Copyright © 2019 Stitch |
Member
There was a problem hiding this comment.
I think we should consider adding the below -
Copyright © 2020–2025 Stitch
Member
|
Please review the schema files and make sure that primary keys do not have "null" as supported data type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
SAC-29830
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code