Skip to content

Conversation

leobossmann
Copy link

@leobossmann leobossmann commented Aug 27, 2025

The selectedOptions attribute contains information on product variants (e.g. size, color, material). Those attributes were present in the older version of the tap as option1, option2, option3 and were missing from the new version

Description of change

  • Add fields to schema (name/value for selectedOptions)
  • Add stream config (array containing selectedOptions objects)

QA steps

Risks

Moderate, no code changes, just modifications to GraphQL schema and stream config

Rollback steps

  • revert this branch

AI generated code

GitHub Copilot was used for research, bug fixing and code completion. All code was reviewed manually before committing

The selectedOptions attribute contains information on product variants
(e.g. size, color, material). Those attributes were present in the older
version of the tap as option1, option2, option3 and were missing from
the new version.
@sgandhi1311 sgandhi1311 self-requested a review August 28, 2025 10:23
@leobossmann
Copy link
Author

I believe the CircleCI run to fail

I tried to run most of the tasks in .circleci/config.yml manually:

  • pylint tap_shopify -d missing-docstring,too-many-branches,consider-using-f-string,consider-using-generator,consider-using-dict-items,unnecessary-dunder-call,duplicate-code,too-many-lines passes without issue
  • JSON Schema validation (custom script) found an error in tap_shopify/schemas/fulfillment_orders.json. Fixed in Fix fulfillment order JSON schema #240
  • coverage run -m pytest tests/unittests failed in tests/unittests/tast_date_window.py. Fixed in Fix typo in assertion method #241

Once these are merged (and integration tests pass) CircleCI build should be successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant