Revert "Bump python 396 (#130)" #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f229588.
zachharris1
commented
Nov 29, 2021
| @@ -34,7 +34,8 @@ jobs: | |||
| command: | | |||
| source dev_env.sh | |||
| source /usr/local/share/virtualenvs/tap-tester/bin/activate | |||
| pip install psycopg2==2.8.6 | |||
| apt install -y libpq-dev | |||
| pip install psycopg2==2.8.4 | |||
There was a problem hiding this comment.
This is worth providing some context. Tap-tester is running python 3.9 but the tap is on 3.5.6.
3.9 is incompatible with psycopg2==2.7.4 so it needs psycopg2==2.8.4 (tap-tester uses psycopg2 to set up the db in the tests)
3.5.6 is incompatible with psycopg2==2.8.4 so it needs psycopg2==2.7.4
cosimon
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #130
Description of change
#130 was merged with the intention that we would be bumping to 3.9.6. However, we've found a potential bug introduced in python 3.6.0. We're opting to revert this for now.
QA steps
Risks
None, this reverts to a working commit
Rollback steps