Implement pagination for Forms stream #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgandhi1311
reviewed
Jul 25, 2024
tap_hubspot/__init__.py
Outdated
| if record[bookmark_key] >= max_bk_value: | ||
| max_bk_value = record[bookmark_key] | ||
| # Check for pagination | ||
| params = {'formTypes': 'ALL', |
There was a problem hiding this comment.
Any significance of adding formTypes=ALL in params?
There was a problem hiding this comment.
This is optional parameter, we can remove it.
added 2 commits
July 25, 2024 11:58
sgandhi1311
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Support ticket: TDL-26309
Implement pagination for forms endpoint to fix
504 Server Error: Gateway Time-out.Manual QA steps
Risks
Rollback steps