Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transform function to drop date of time fields #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luandy64
Copy link
Contributor

@luandy64 luandy64 commented Feb 8, 2021

Description of change

This PR transforms Google Sheet Time fields from "44241 days, 12:34:56" to "12:34:56"

Manual QA steps

  • Ran the tap with target-stitch's `Validating Handler

Risks

  • Low, the current tap errors because "44241 days, 12:34:56" is not a valid time format. So no downstream system should ever see a value like this.

Rollback steps

  • revert this branch, bump the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant