use updated_after & updated_before param for bookmarking in conv & messages.
#8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nger-io/tap-dixa into TDL-19674-bookmarking_strategy_bugfix
Co-authored-by: Collin Simon <cosimon@users.noreply.github.com>
…nger-io/tap-dixa into TDL-19674-bookmarking_strategy_bugfix
cngpowered
changed the title
|
Looks good to me |
kethan1122
approved these changes
Jul 7, 2022
cngpowered
changed the title
updated_after & updated_before param for bookmarking in conv & messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes to the replication filter used for conversations stream
updated_after/beforefilter params instead ofcreated_after/beforefor fetching records in incremental synccreated_atinstead of current ust timestampManual QA steps
Risks
Rollback steps