Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDL-9902 removed the automatic fields from ad ext report #85

Merged
merged 9 commits into from
Dec 29, 2021
Merged

TDL-9902 removed the automatic fields from ad ext report #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3198116
TDL-9902 removed the automatic fields from ad ext report
namrata270998 Oct 6, 2021
4cc3147
Added coverage report in artifact
prijendev Oct 21, 2021
52b84e2
revert back config.yml file
prijendev Oct 21, 2021
e68f7d2
Merge branch 'TDL-10048-Improve-BingAds-Reliability' of https://githu…
namrata270998 Nov 8, 2021
e5a1a7f
resolved comments
namrata270998 Dec 16, 2021
898413f
Merge branch 'TDL-10048-Improve-BingAds-Reliability' of https://githu…
prijendev Dec 22, 2021
b0b113b
Merge branch 'TDL-10048-Improve-BingAds-Reliability' of https://githu…
namrata270998 Dec 22, 2021
14ef729
Merge branch 'TDL-10048-Improve-BingAds-Reliability' of https://githu…
namrata270998 Dec 29, 2021
9483bc8
Merge branch 'TDL-9902-update-auto-fields-for-ext-details' of https:/…
namrata270998 Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tap_bing_ads/reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,7 @@
'AdExtensionId',
'AdExtensionPropertyValue',
'AdExtensionType',
'AdExtensionTypeId',
'Clicks',
'Ctr',
'Impressions'
'AdExtensionTypeId' # removed `Impressions`, `Ctr,`, and `Clicks` from the required fields of `AdExtensionDetailReport`
],
'GoalsAndFunnelsReport': ['Goal'],
# added required fields for `AgeGenderAudienceReport` as mentioned in the bing-ads docs
Expand Down
3 changes: 1 addition & 2 deletions tests/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ def expected_metadata(self):
# 'Impressions', 'Ctr', 'Clicks' shouldn't be automatic
extension_report = copy.deepcopy(default_report)
extension_report[self.REQUIRED_KEYS] = {
'AdExtensionId', 'AdExtensionPropertyValue', 'AdExtensionType', 'AdExtensionTypeId',
'Impressions', 'Ctr', 'Clicks' # Comment this line to reproduce BUG_SRCE-4578
'AdExtensionId', 'AdExtensionPropertyValue', 'AdExtensionType', 'AdExtensionTypeId'
}

age_gender_report = copy.deepcopy(default_report)
Expand Down