Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove null characters from the CSV #78

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Remove null characters from the CSV #78

merged 1 commit into from
Apr 23, 2021

Conversation

cosimon
Copy link
Contributor

@cosimon cosimon commented Apr 23, 2021

Description of change

Remove null characters from the CSV.

Manual QA steps

  • Ran on a connection which was failing due to null characters coming through the CSV file streamed from Bing ads. Running on master the sync failed, running on this branch the sync succeeded.

Risks

  • This is a pattern we have used for CSV readers in other taps and any Bing ads reports this would affect would be failing without this change.

Rollback steps

  • revert this branch

@cosimon cosimon merged commit 1e5ff5f into master Apr 23, 2021
@cosimon cosimon deleted the fix/remove-null-chars-from-csv branch April 23, 2021 19:15
@cosimon cosimon mentioned this pull request Apr 23, 2021
Merged
prijendev pushed a commit that referenced this pull request Oct 7, 2021
@cosimon
Remove null characters from the CSV (#78)
24d088f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KAllan357 KAllan357 KAllan357 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosimon @KAllan357