Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exclusions to match the second set of pairs in docs #56

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

dmosorast
Copy link
Contributor

@dmosorast dmosorast commented Jul 21, 2020

Description of change

The documentation on reports and the fields that can be selected with other fields is rather misleading. There is a table with two groups of fields that are mutually exclusive, but above that, there is another set of groups in a purple comment that are ALSO (differently) mutually exclusive.

Documentation can be found here: https://docs.microsoft.com/en-us/advertising/guides/reports?view=bingads-13#columnrestrictions

Manual QA steps

  • I confirmed that the parenthetical groups were mutually exclusive regardless of the table
  • Ran a report to confirm that for ad_group_performance and campaign_performance

Risks

  • Low, this is not matching Microsoft's pattern as it is, and most exclusion reports/fields documented are not even offered in the tap.

Rollback steps

  • revert this branch and release new minor version

@dmosorast dmosorast merged commit b2dc737 into master Jul 22, 2020
@dmosorast dmosorast deleted the fix/exclusions-pattern-and-values branch July 22, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants