Add optional 'tenant' config option #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing the "tenant ID" of a single tenant (single organization) app is necessary for successful authentication, as they cannot be authorized via the /common endpoint. Additionally, a developer cannot easily choose to configure an app intended for internal use only as a multi-tenant app, because multi-tenant app now require signing up as a Microsoft Partner. This new config option is entirely optional, and it defaults to "common" to preserve existing behaviour by default.
|
Hi @robotfelix, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Providing the "tenant ID" of a single tenant (single organization) app is necessary for successful authentication, as they cannot be authorized via the /common endpoint. Additionally, a developer cannot easily choose to configure an app intended for internal use only as a multi-tenant app to work around this, because multi-tenant apps now require signing up as a Microsoft Partner.
This PR allows new "tenant" config option to be passed to specify a "tenant ID" to use, which is already a supported by the underlying Bing Ads API Python SDK. The config option is entirely optional, and it defaults to "common" to preserve existing behaviour by default ("common" is the value the Bing Ads API Python SDK is already using by default since this tap is currently not providing the optional argument).
Manual QA steps
Risks
Rollback steps