Fix/validate image on site #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mreq
requested changes
Oct 16, 2025
Member
mreq
left a comment
mreq
left a comment
There was a problem hiding this comment.
v multi pickeru http://dummy.localhost:3002/console/ui/file_placements_multi_picker_fields
i ve vyberu coveru pro stranku http://dummy.localhost:3002/console/pages/dummy/edit
Zasednuti a varovani se ukazuje spravne, ale soubor muzu normalne vybrat, ac se ma jiz vyplemcane sve 1 maximalni pouziti. Stranka pak lze normalne ulozit a pocet vyuziti se navysi na 2.
| end | ||
| else | ||
| stimulus_action({ click: "primaryAction" }) | ||
| if @primary_action.to_s == 'index_for_modal' && !allow_selection_for_site? |
Member
There was a problem hiding this comment.
tohle bych zmenil na != "index", protoze v pripade multi pickeru take nechci, aby to slo vybrat http://dummy.localhost:3000/console/ui/file_placements_multi_picker_fields
mreq
approved these changes
Oct 16, 2025
jzlamal
pushed a commit
that referenced
this pull request
Oct 29, 2025
* fix: do not allow to select image if it is not allowed for current site --------- Co-authored-by: Petr Marek <contact@petrmarek.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-10-16.at.12.44.27.mov
Screen.Recording.2025-10-16.at.13.54.08.mov
Jak by to mělo fungovat
Případ 1: Uživatel je na webu XXX a chce vybrat obrázek, který je nastaven pro web YYY => uživatel jej nemůže přidat do článku
Případ 2: Uživatel je na webu XXX a chce vybrat obrázek, který je nastaven pro web XXX, ale má limit nastavený na 1 a již byl použit => uživatel jej nemůže přidat do článku
Případ 3: Uživatel je na webu XXX a chce vybrat obrázek, který je nastaven pro web XXX => uživatel jej může přidat
Pridano screen record s ukazkou