fix: Minor updates for media sources #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zanetagebka
commented
Oct 8, 2025
zanetagebka
commented
mreq
requested changes
Oct 10, 2025
| end | ||
| ensure | ||
| @nullified_file_ids = nil | ||
| end |
Member
There was a problem hiding this comment.
Chybi test. Folio::MediaSource nema zadny test? Prosim doplnit
Contributor
Author
There was a problem hiding this comment.
Pridano. Opraveno taky before_delete aby to rusilo taky sites_links pridane pres media_source
app/models/folio/tiptap/node.rb
Outdated
|
|
||
| file = file_klass.find_by(id: file_id) | ||
| file && !file.can_be_used_on_site?(site) | ||
| end |
app/models/folio/tiptap/node.rb
Outdated
| Rails.logger.error("Folio::Tiptap site validation error: #{e.message}") if defined?(Rails) | ||
| end | ||
|
|
||
| def file_invalid_for_site?(placement_hash, file_klass, site) |
Member
There was a problem hiding this comment.
Tohle nezni jako vec, ktera by mela byt na Folio::Tiptap::Node, ale nekde jinde
mreq
requested changes
Oct 16, 2025
Member
mreq
left a comment
mreq
left a comment
There was a problem hiding this comment.
Diky za doplneni testu 👍
Nelibi se mi obcasne predavani site do node pro potreby validace. Bud
- musi mit node vzdy
record(ktery muze mit site a pak lze resit validace) - nebo lepe omezme vyber obrazku jen na pouzitelne. Pak neni potreba validovat primo na node, ale staci obecne na zaznamu, jehoz je node skrze tiptap content soucasti.
Klidne si na to zavolejme, dik
jzlamal
pushed a commit
that referenced
this pull request
Oct 29, 2025
* fix: selectedOptions.map.map is not a function, add missing locale, add alert about missing alt --------- Co-authored-by: Petr Marek <contact@petrmarek.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.