Added cmd-line option for stripping fragments and fixing relative paths in markdown/img images #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 6, 2017 14:25
…which are useful for getting handouts). Moreover, there's a fix for relative image paths expressed either as markdown images (i.e., with the ![]() syntac) or as html images (i.e., with the <img> tag). In particular, the relative image paths in case of export and pdf are resolved to the absolute path in order to properly have the image included in the output.
|
Thanks for the PR, those are nice additions! Before merging, could you change 2 little things?
|
…ses. Removed the version bump in package.json and CHANGELOG.md
|
I did it. By the way, if you're interested, I could also work on a further addition to inline external images referred in the markdown file (currently they are just externally linked, that's the reason why I was forced to fix the path). Would you be interested? |
liuq
changed the title
|
Thanks, it's perfect 👍 Inlining external images would be a great addition, I would gladly accept the PR ❤️ |
|
Just for info, I changed the usage doc a bit to fit 80 chars wide terminals and fixed the handouts options being enabled by default for pdf export (it could not be disabled). I published a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a command-line option (-h --handouts) for stripping pauses from presentations (which are useful for getting handouts).
Moreover, there's a fix for relative image paths expressed either as markdown images (i.e., with the![]()
syntax) or as html images (i.e., with the <img> tag).
In particular, the relative image paths in case of export and pdf are resolved to the absolute paths in order to properly have the image included in the output.