-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement types schema option parameter #385
feat: implement types schema option parameter #385
Conversation
c477f6d
to
419fc0e
Compare
Thanks for working on this |
d3839a0
to
dc07897
Compare
Thanks for the feedback @sindresorhus! I've done a second pass of the doc comments and tried to get it as concise and clear as possible. Let me know if there's any areas you think need reworking 💪 |
It also needs to be added to the readme. I would wait until the TS docs are done. It should be as close to the TS docs as possible. |
Thanks for taking another look at my changes @sindresorhus 💪 I've made the corrections, and have added additional context in the TS Docs. Let me know if they look good to you, and I'll get the readme updated accordingly. |
Looks good 👍 |
That's great @sindresorhus , I've updated the |
Thanks for contributing 🙏 |
Hi @sindresorhus, I decided to pick up this feature request. I used your comments on this PR: #249 to help guide me on implementation requirements.
Resolves #210
related to #201
Let me know if you have any feedback!