Remove abort listener when operation completes #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleRoets-Work
approved these changes
Nov 17, 2025
kheyse
force-pushed
the
feature/remove-abort-listener
branch
2 times, most recently
from
968625f to
f710069
Compare
kheyse
force-pushed
the
feature/remove-abort-listener
branch
from
f710069 to
f444dce
Compare
Contributor
Author
|
Thank you for the quick response 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not clean up the listeners it adds to the abortsignal.
When doing many operations using a single abortcontroller, that is only eventually or never aborted, this results in memory-leak-like behaviour.