Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve example readability #13

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Slightly improve example readability #13

merged 1 commit into from
Nov 23, 2020

Conversation

papb
Copy link
Contributor

@papb papb commented Nov 23, 2020

I think it's easier to see the async wrapper around the whole code:

(async () => {
    // Having the whole code here is better...
    // You quickly see this wrapper and says 'ok this is here just to enable using `await`' and then you forget about it
})();

I know this is subjective though; feel free to reject this PR.

@sindresorhus sindresorhus merged commit 577b66e into sindresorhus:master Nov 23, 2020
@papb papb deleted the patch-1 branch November 23, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants