add missing test for target being a primitive #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,6 +100,13 @@ it('should preserve property order', function () { | |||
| assert.equal(Object.keys(target).join(''), letters); | |||
| }); | |||
|
|
|||
| it('target can be primatives', function () { | |||
There was a problem hiding this comment.
Although I'd rather see AVA as testing framework, if mocha is used, the convention of titles is more like this:
it('should accept primitives as target', function () {
stevemao
force-pushed
the
primatives-test
branch
from
7491a10 to
d899158
Compare
| @@ -5,7 +5,7 @@ var assert = require('assert'); | |||
| Object.assign = undefined; | |||
| var objectAssign = require('./'); | |||
|
|
|||
| it('should have the correct length', function () { | |||
| it('should expect at least 2 arguments', function () { | |||
There was a problem hiding this comment.
This is incorrect. It's testing how many arguments are there in the code, just what's passed.
There was a problem hiding this comment.
Also, don't do unrelated changes when doing a PR ;)
There was a problem hiding this comment.
Hmm... from mdn, it should mean the number of arguments expected by the function.
There was a problem hiding this comment.
arguments.length is how many arguments.
sindresorhus
changed the title
stevemao
force-pushed
the
primatives-test
branch
from
d899158 to
2d4b89e
Compare
|
I removed unrelated changes |
stevemao
force-pushed
the
primatives-test
branch
from
2d4b89e to
b199aa6
Compare
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.