Support setting flags globally and locally using cosmiconfig

[itaisteinherz]

Fixes #279.

// cc @voxpelli Let me know what you think and if you have any suggestions on how to improve this.

[aladdin-add]

LGTM, do we need to document it somewhere?

[itaisteinherz]

do we need to document it somewhere?

This should be documented in the readme, in its own section.

[itaisteinherz]

@sindresorhus I addressed #279 (comment) in 67fb219.

[sindresorhus]

The code looks good, but haven't tested it yet. Can you add the docs?

[sindresorhus]

I think we should allow .np-config.js too.

[itaisteinherz]

Can you add the docs?

Sure

I think we should allow .np-config.js too.

Done

[sindresorhus]

We could really use some tests for this.

[itaisteinherz]

We could really use some tests for this.

I'm not really sure how this should be tested. For local configs, I guess we could create some fixtures to test out the behavior, but I have no idea how to mock is-installed-globally to test global configs. I suppose we could use something like proxyquire / mockery / rewiremock.

[sindresorhus]

I just feel like we add more and more functionality and we have basically no tests.

[itaisteinherz]

I just feel like we add more and more functionality and we have basically no tests.

It bothers me as well. I think that this could be improved by:

1. Splitting Add more tests #29 into smaller, more manageable, specific and actionable issues (e.g. Add tests for Git tasks).
2. Allocating IssueHunt bounties to each issue (in case those are available to you, of course).

I'll also try to work on adding more tests (and add tests here as well).

[itaisteinherz]

@sindresorhus Also see #354 (comment).

[sindresorhus]

Splitting #29 into smaller, more manageable, specific and actionable issues (e.g. Add tests for Git tasks).

👍 Would you be up for doing that?

Allocating IssueHunt bounties to each issue (in case those are available to you, of course).

Yup. Can do.

[sindresorhus]

I'll also try to work on adding more tests (and add tests here as well).

Can you open an issue or follow-up PR about that?

[sindresorhus]

Manually tested this and works well.

[itaisteinherz]

👍 Would you be up for doing that?

Sure (will probably get it done in the next few days).

Can you open an issue or follow-up PR about that?

👌🏻

[itaisteinherz]

@sindresorhus It would be great if you could reward me on IssueHunt for this and #334 🙃

[itaisteinherz]

Also, it seems like this breaks using $ np and $ np [increment]. @sindresorhus Can you verify? This seems like a quite severe issue. I'll try to get it fixed ASAP.

Edit: I also get a triple increment when using $ np [increment] (e.g. running $ np patch when current version is v4.0.0 releases v4.0.3 - see itaisteinherz/itai-playground@4def1f0 and https://npm.im/itai-playground). Probably unrelated to this though.