-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing test
run script should not fail np
when using Yarn
#275
Comments
…the release. See issue sindresorhus/np#275
This comment has been minimized.
This comment has been minimized.
I have a feeling this is caused by Lines 17 to 25 in cec8e00
stream-to-observable , but I haven't looked closely into it.
|
@issuehuntfest has funded $80.00 to this issue. See it on IssueHunt |
@sindresorhus running |
@Norris1z Yup, but another part of the problem that needs to be fixed is that it only shows the error on exit, and doesn't affect the |
@sindresorhus you're right. It is a problem with the Observables. title: "Running tests using Yarn",
enabled: () => opts.yarn === true,
task: () =>
execa.stdout("yarn", ["test"]).catch(error => {
if (!error.message.includes('Command "test" not found')) {
throw new Error(error);
}
}) This method works great. Should i submit a pr for this or we should still debug the Observables? |
@Norris1z We need to use Observables so the child process output is streamed into the task output. With your change the test output will only be shown when it's done.
Yes |
@sindresorhus i found out that somehow after the failed |
@dflupu has submitted a pull request. See it on IssueHunt |
@sindresorhus has rewarded $72.00 to @dflupu. See it on IssueHunt
|
When using npm it just exists with code 0 when the
test
script is missing, but when using Yarn it exists with code 1. I've partially fixed it in acbaece, it passes the step, but it still shows an error message after exiting.The text was updated successfully, but these errors were encountered: