Skip to content

Conversation

notlmn
Copy link
Collaborator

@notlmn notlmn commented Jul 20, 2024

Fixes: #297

  • Move background to a service worker
  • Move audio playback to offscreen file
  • Convert script types to modules in options and offscreen
  • Update minimum browser versions for Chrome and Firefox
  • Update dev dependencies as needed
  • Update tests as needed (remove some individual tests)
  • Disable badge-test as sinon-chrome does not have stub for browser.action API
  • Disable auto-publishing to AMO due to lack of offscreen API in Firefox

@notlmn notlmn marked this pull request as draft July 20, 2024 11:09
@notlmn notlmn mentioned this pull request Jul 20, 2024
@notlmn
Copy link
Collaborator Author

notlmn commented Aug 5, 2024

@sindresorhus can you do a manual release to CWS from this branch instead of the default one? Or do you have any other suggestions for working around v2 and v3 releases.

This one fails to run for Firefox because there's no offscreen API in Firefox yet.

@sindresorhus
Copy link
Owner

I think it would be better to just disable Firefox auto-publishing for now: https://github.com/sindresorhus/notifier-for-github/blob/main/.github/workflows/release.yml

@notlmn notlmn marked this pull request as ready for review August 17, 2024 12:07
@notlmn notlmn requested a review from sindresorhus August 17, 2024 12:17
@sindresorhus sindresorhus merged commit 8b726b7 into main Aug 17, 2024
@sindresorhus sindresorhus deleted the mv3 branch August 17, 2024 12:26
@notlmn notlmn mentioned this pull request Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

URGENT: Manifest v3

2 participants