Update AVA #254
Merged
Update AVA #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
Apr 7, 2021
test/api-test.js
Outdated
| }); | ||
|
|
||
| await t.throwsAsync(() => service.makeApiRequest('notifications'), 'client error'); | ||
| await t.throwsAsync(() => service.makeApiRequest('notifications'), { |
There was a problem hiding this comment.
How can t.throwsAsync catch and compare the error if the call throws before its result is passed to t.throwsAsync? 🤔
There was a problem hiding this comment.
It doesn't throw. makeApiRequest returns a promise. You pass a promise to throwsAsync and it checks whether it rejects or not.
There was a problem hiding this comment.
Promises, how do they work
|
@fregante thank you for this while I am MIA out of OSS! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
Follows and is based on #253