Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Node.js 10 #103

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Require Node.js 10 #103

merged 2 commits into from
Jan 31, 2020

Conversation

TrySound
Copy link
Contributor

@TrySound TrySound commented Jan 6, 2020

Node 8 is end-of-life. We can use only URL global.

@TrySound
Drop node 8 support
eaaaddf 
Node 8 is end-of-life. We can use only URL global.
@sindresorhus
Copy link
Owner

You need to update package.json too.

@sindresorhus sindresorhus changed the title Drop node 8 support Require Node.js 10 Jan 6, 2020
@TrySound
Copy link
Contributor Author

TrySound commented Jan 6, 2020

@sindresorhus Done

@TrySound
Copy link
Contributor Author

Hi @sindresorhus
Friendly ping in case you missed update

@TrySound
Copy link
Contributor Author

Hi @sindresorhus Is everything good now?

@sindresorhus sindresorhus merged commit 7b4ad64 into sindresorhus:master Jan 31, 2020
@sindresorhus
Copy link
Owner

Yeah, I just didn't see the urgency with this.

@TrySound TrySound deleted the drop-node-8-support branch January 31, 2020 15:01
@sindresorhus
Copy link
Owner

https://github.com/sindresorhus/normalize-url/releases/tag/v5.0.0

FAVE01
FAVE01 reviewed Nov 8, 2021
View reviewed changes
Copy link

@FAVE01 FAVE01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FAVE01 FAVE01 FAVE01 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrySound @sindresorhus @FAVE01