Allow running Node modules binaries on Windows #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome to see you managed this in so little code 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12.
By default, on Windows,
node:child_processdoes not allow runningnpmnor any Node modules binary (without doing some tricks). This PR fixes this.As a side effect, this PR also fixes support for the
PATHEXTenvironment variable on Windows. As another side effect, it allows running.cmdand.batfiles.This is basically a reduced version of what Execa (through
node-cross-spawnand its dependencywhich) is doing, but in much fewer bytes, and minus shebang support (which would be slightly too big to implement).