Fix <table> declarations #79
Merged
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
text-indentreset is fixed in all browsers, and I have tested that they work:The
border-colorinheritance issue is not yet fixed, but I believe the current implementation inmodern-normalizeis incorrect. I have made a test document to show what I mean.Source: https://codepen.io/atjn/full/yLdowBM
In these pictures, you see a comparison between Firefox (left), WebKit (middle), and Chromium (right).
In the first picture, we see how browsers handle inheritance by default:
I would argue that Firefox's approach is best here, and it is also the only one to pass the web platform tests for table borders, so we should replicate what Firefox does.
In the second picture, we see what
modern-normalizecurrently does:This does not replicate Firefox's approach and is in my opinion not very usable.
In the third picture, we see what my proposed solution would do:
This solution perfectly replicates Firefox's approach across all browsers.