-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide system fonts #3
Comments
@anselmh Are you downvoting including system fonts by default or also just as a variable? And why? |
Sorry, voted first, now here are my detailed two thoughts on it. Note that I’m not 100% convinced whether my thoughts are correct, so take it with a salt of grain:
2.1 If this makes it into the codebase I like the idea of setting it as CSS custom property and only on demand. |
Browsers already ship with a default font family, this just normalizes it. That's how I look at it at least. |
Well but shouldn’t the goal be a visual equal look? This would mean something like I personally see normalization as a strive for parity which in this case is not the goal if system fonts are set. Maybe my thoughts are erroneous as most people would prefer to have |
I realize my proposal will not result in full normalization, but it is better than the browser default. At least setting the |
In which case I think best would be to set this directly, as originally suggested by you and not provide an opt-in via CSS Custom Property. Thanks for this discussion, it actually changed my views on this. 🙂 |
@sindresorhus Did you see @mdo's blog post on Shipping system fonts to GitHub.com? They've changed the defaults for various reasons mentioned in the post: body {
font-family:
'-apple-system',
- 'system-ui',
'BlinkMacSystemFont',
'Segoe UI',
- 'Roboto',
- 'Helvetica Neue',
+ 'Helvetica',
'Arial',
'sans-serif',
'Apple Color Emoji',
'Segoe UI Emoji',
'Segoe UI Symbol';
} |
@khellang It's a good read, but it's missing specifics. The |
PR is up. I could use a review: #16 |
@> It doesn't say why they switched from
|
I think adding font related properties shouldn't be a part of normalization css files. |
@Altug Please read the whole discussion. The argument is that it is a normalization. |
The standard and non-standard ways to select system fonts are too much in flux IMO to offer a specific solution in a “normalize” stylesheet. I also like the |
My blog post was written over a year ago, so there's some stuff that's off and already changed since then. Did my best to call those out where I could. We had issues with The font stack and my post don't match up though with what's there currently with Helvetica vs Helvetica Neue. I will say that from experience, Helvetica Neue has much different behaviors with vertical alignment compared to Helvetica. It's a superior font for macOS IMO, but clearly something was jumbled either on my end or the stack itself. Definitely needs looking into as my gut tells me we should have Helvetica Neue and Helvetica in there given Windows aliases Helvetica outright to Arial. |
Are there any downsides to setting this by default?
Users then get good defaults but can override it with their own
body
selector if they want.Alternatively, if this gets a lot of resistance, we could provide a CSS variable, so users who want it can just do:
Thoughts?
(If you 👎 please also share your thoughts on why)
The text was updated successfully, but these errors were encountered: