Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically use WeakMap when possible #56

Merged
merged 5 commits into from
Apr 12, 2020
Merged

Automatically use WeakMap when possible #56

merged 5 commits into from
Apr 12, 2020

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented Apr 10, 2020 •
edited
Loading

mem doesn't need Map, it's just that WeakMap doesn't support most primitives. If it could, it should only use WeakMap

Proposal: use WeakMap...

  • if cache isn't provided by the user
  • when the current key is supported by WeakMap

This is automatic and silent.

@sindresorhus
Copy link
Owner

It needs to be documented though: https://github.com/sindresorhus/mem#cache

fregante
fregante commented Apr 10, 2020
View reviewed changes
readme.md Show resolved Hide resolved
@sindresorhus sindresorhus merged commit e8bb86c into master Apr 12, 2020
@sindresorhus sindresorhus deleted the Auto-WeakMap branch April 12, 2020 14:18
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Merged
fregante added a commit that referenced this pull request May 16, 2020
@fregante
Revert "Automatically use WeakMap when possible (#56)"
8fc8766 
This reverts commit e8bb86c.
@BitcoinOutput BitcoinOutput mentioned this pull request Sep 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fregante @sindresorhus