Skip to content

💄 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2016
Merged

💄 #8

merged 1 commit into from
Jun 17, 2016

Conversation

SamVerschueren
Copy link
Contributor

  • Add XO
  • Add AVA
  • 💄

SamVerschueren
SamVerschueren reviewed Jun 17, 2016
View reviewed changes
index.js
@@ -6,7 +6,7 @@ module.exports = function (str, indent, count) {
throw new TypeError('`string` and `indent` should be strings');
}

if (count != null && typeof count !== 'number') {
if (count !== undefined && typeof count !== 'number') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be count !== undefined && count !== null && typeof count !== 'number'?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I don't check against null anymore as it won't work with default arguments anyways, as those are only valid for undefined, not null.

@sindresorhus sindresorhus merged commit 0082a7d into master Jun 17, 2016
@sindresorhus sindresorhus deleted the lipstickify branch June 17, 2016 20:43
@sindresorhus
Copy link
Owner

💄💄💄💄💄💄💄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamVerschueren @sindresorhus