-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for doing the hashing in a worker thread #16
Comments
I like it. It's usually not super expensive, but a 1gb file shasum takes ~4s on my macbook 2015 2.8 GHz Intel Core i7 I would actually prefer a C++ binding (that I'd guess would be faster, since in OS X for example, running |
Not interested in doing native bindings. That comes it its own set of horribleness. |
Related to sindresorhus/crypto-hash#7 // @stroncium |
Can easily be done for file hashes(and will work perfectly). Speaking of performance comparison with openssl, it sounds strange to me, as node is using openssl underneath. If such issue actually exists it could use some serious debugging on libuv/nodejs/app level. |
@IssueHunt has funded $80.00 to this issue.
|
On it. |
Does |
@sindresorhus Need to check it, but should be enough. |
@sindresorhus Never mind. I didn't notice there was no async version of |
Sorry if the issue was not clear enough on this, but the intention is to add it now that it's possible. |
@sindresorhus Well, then there are some questions:
|
Additional method.
Nah
Probably not worth using |
@sindresorhus has rewarded $72.00 to @stroncium. See it on IssueHunt
|
Could maybe be useful for hashing large files, as the crypto Node.js module is synchronous, so it could block the main thread for some time.
https://nodejs.org/api/worker_threads.html
Thoughts?
IssueHunt Summary
stroncium has been rewarded.
Backers (Total: $80.00)
Submitted pull Requests
Tips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: