Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to version 7.0.0 makes now use of execa option
localDir
. The latter package does now the actual call tonpmRunPath
.But in order for the change to be seemless in gulp-mocha, the option
preferLocal
when calling execa must be set to true, otherwise the arrow functiongetEnv
in execa will ignore it.Moreover
subprocess.stdout.pipe(subprocess.stdout);
looked suspicious to me. I checked against gulp-mocha@6 and it used to be piped intoprocess
stdios. So I replaced pipingsubprocess
stdios into themselves by their piping intoprocess
stdios.npm run test
didn't show any error after the changes, the 4 tests still pass.Fixes #196