-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ava and @sindresorhus/tsconfig #2109
Conversation
- Remove nonSemVerExperiments which is no longer experimental in V4 - Comply with ava.Macro V4 format - Use ! operator after ava.throwsAsync which can return undefined in V4
source/core/index.ts
Outdated
& ((name: 'uploadProgress' | 'downloadProgress', listener: (progress: Progress) => void) => T) | ||
/** | ||
To enable retrying on a Got stream, it is required to have a `retry` handler attached. | ||
|
||
When this event is emitted, you should reset the stream you were writing to and prepare the body again. | ||
|
||
See `got.options.retry` for more information. | ||
*/ | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't make unrelated changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDE auto-indent shenanigans :(
Fixed
"target": "es2020", // Node.js 14 | ||
"lib": [ | ||
"es2020" | ||
"moduleResolution": "Node", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Atm got 12.3.1 has moduleResolution=Node
inherited from @sindresorhus/tsconfig 2.0.0
Switching to @sindresorhus/tsconfig 3.0.1
sets moduleResolution
to Node16
which breaks type checking when building got (due to issues with how some packages interact with moduleReolution=Node16
, see debugging attempts in #2051 (comment) )
Overriding moduleResolution to Node here allows to upgrade tsconfig without breaking the package.
It should ultimately be removed when the resolution with the problematic packages is okay.
I added a comment in the file, does that sound reasonable?
I botched unit tests because ava cannot interpret typescript transpiled with module:Node16 Quick question @szmarczak, I see you're a maintainer of https://github.com/avajs/typescript, should it be added to this project? Also unit test can't run properly on my setup, but there are a few that actually broke due to a FakeTimer issue, looking into it
|
These are unrelated changes and should be done in a separate pull request. |
|
Closing in favor of 8630815 and #2051 (comment). Help welcome getting the dependencies fixed. |
Following discussions on #2051
ava
to V4@sindresorhus/tsconfig
to 3.0.1Checklist