Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bug: when a binary stream is converted to a string using
getStream()
, if it contains UTF8 multibyte sequences which are split in-between multiple chunks, this results in a broken output.This PR addresses this by using
new TextDecoder()
in stream mode.Note: this is also how core Node.js implements this in the
node:stream/consumers
text()
method.https://github.com/nodejs/node/blob/6432060c7ce1670467c230d2c0c925465dd311f8/lib/stream/consumers.js#L57-L70