Truncate error.bufferedData if too large
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Aug 8, 2023
| try { | ||
| return getBufferedValue(chunks.slice(0, chunksCount), isBuffer); | ||
| } catch {} | ||
| } while (chunksCount > 0); |
There was a problem hiding this comment.
chunksCount > 0 should never be false, since when chunksCount = 0 is called, chunks.slice(0, 0) will be an empty string/buffer, which is guaranteed not to throw.
So, one could use while (true) instead. I have used chunksCount > 0 instead to avoid some linting warning, and as an additional safety net to avoid infinite loops, just in case.
ehmicky
commented
Aug 8, 2023
index.d.ts
Outdated
| */ | ||
| readonly encoding?: EncodingType; | ||
| } & Options; | ||
|
|
There was a problem hiding this comment.
Most of this PR's changes are from #69 (see PR description).
|
Conflict |
|
Fixed 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
error.bufferedDatais too large, it is not set instead.With this PR,
error.bufferedDatais still set, but with a smaller string/buffer. If the stream is too large, having the first bytes of it can prove to be very useful for debugging.