Add TypeScript definition #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide? Some examples: |
|
font{
line-height: 1.6;
}
ul,ol{
padding-left: 20px;
list-style-position: inside;
}
OK！
Ys
On 11/14/2019 11:32，Sindre Sorhus<notifications@github.com> wrote：
Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide?
Some examples:
sindresorhus/semver-regex@039944b
sindresorhus/global-directory@0aae4d6
sindresorhus/md5-hex@bbbfeff
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.
|
facebook-github-bot
pushed a commit
to facebook/flipper
that referenced
this pull request
Feb 17, 2020
Summary: ## The dependency [fix-path](https://github.com/sindresorhus/fix-path) was updated from `2.1.0` to `3.0.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- **Publisher:** [sindresorhus](https://www.npmjs.com/~sindresorhus) **License:** MIT <details> <summary>Release Notes for v3.0.0</summary> <h3>Breaking</h3> <ul> <li>Require Node.js 10 <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/fix-path/commit/41133a9fa65f58cb7013fb49c6c80cb5171c9ed3/hovercard" href="https://urls.greenkeeper.io/sindresorhus/fix-path/commit/41133a9fa65f58cb7013fb49c6c80cb5171c9ed3"><tt>41133a9</tt></a></li> </ul> <h3>Enhancements</h3> <ul> <li>Add TypeScript definition (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="522596993" data-permission-text="Issue title is private" data-url="sindresorhus/fix-path#12" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/fix-path/pull/12/hovercard" href="https://urls.greenkeeper.io/sindresorhus/fix-path/pull/12">https://github.com/facebook/flipper/issues/12</a>) <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/fix-path/commit/096036c297fb201e0bfa37e146e50a45073e424b/hovercard" href="https://urls.greenkeeper.io/sindresorhus/fix-path/commit/096036c297fb201e0bfa37e146e50a45073e424b"><tt>096036c</tt></a></li> </ul> <p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/fix-path/compare/v2.1.0...v3.0.0"><tt>v2.1.0...v3.0.0</tt></a></p> </details> <details> <summary>Commits</summary> <p>The new version differs by 5 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/sindresorhus/fix-path/commit/8f12bec72ee4319638a43758b40d61c25427404b"><code>8f12bec</code></a> <code>3.0.0</code></li> <li><a href="https://urls.greenkeeper.io/sindresorhus/fix-path/commit/41133a9fa65f58cb7013fb49c6c80cb5171c9ed3"><code>41133a9</code></a> <code>Require Node.js 10</code></li> <li><a href="https://urls.greenkeeper.io/sindresorhus/fix-path/commit/096036c297fb201e0bfa37e146e50a45073e424b"><code>096036c</code></a> <code>Add TypeScript definition (https://github.com/facebook/flipper/issues/12)</code></li> <li><a href="https://urls.greenkeeper.io/sindresorhus/fix-path/commit/df806209a2431f4a6819dfaf73d5717b192d3cbb"><code>df80620</code></a> <code>Require Node.js 8</code></li> <li><a href="https://urls.greenkeeper.io/sindresorhus/fix-path/commit/e208dd064da4be703d54259804df1b9d198b4158"><code>e208dd0</code></a> <code>Create funding.yml</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/sindresorhus/fix-path/compare/b9fa7c4ce92507be1bd487e450b2aa06e3f57f0e...8f12bec72ee4319638a43758b40d61c25427404b">full diff</a></p> </details> --- <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Pull Request resolved: #804 Reviewed By: mweststrate Differential Revision: D19938234 Pulled By: passy fbshipit-source-id: b012360396d476d610e79136904052ec7395076d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add typing file