Fix errors being thrown when detached: true or cleanup: false is used

[ehmicky]

Using either the detached: true and cleanup: false always throws an error:

> await execa('echo',{cleanup: false})
Thrown:
TypeError: Cannot destructure property `error` of 'undefined' or 'null'.
    at handlePromise (/home/ether/code/execa/index.js:107:10)
    at processTicksAndRejections (internal/process/task_queues.js:85:5)
> await execa('echo',{detached: true})
Thrown:
TypeError: Cannot destructure property `error` of 'undefined' or 'null'.
    at handlePromise (/home/ether/code/execa/index.js:107:10)
    at processTicksAndRejections (internal/process/task_queues.js:85:5)

This was introduced by one my PRs here.

This is a quite critical bug, we should release this. However the current code contains breaking changes: users of the all property must now use the all: true option. So this would be a major release.

Additionally some tests that check t.throwsAsync() were incorrect but previously successful due to that bug being present (since it made execa fail but for the wrong reason). I have fixed those tests (mostly Windows issues).

[sindresorhus]

This is a quite critical bug, we should release this. However the current code contains breaking changes: users of the all property must now use the all: true option. So this would be a major release.

I don't think we should release the all change yet. I would prefer to resolve #351 first. What we could do is to create a branch based on v2.0.3, apply the one-line fix, and do a v2.0.4 release to an alternative dist-tag. ?

[ehmicky]

Would the following be simpler?

• revert Add all option #353 (all option breaking change)
• release 2.0.4
• add Add all option #353 back

[sindresorhus]

I prefer doing it from a branch. That way the main commit history doesn't get the revert noise.

Done: https://github.com/sindresorhus/execa/releases/tag/v2.0.4

---

and do a v2.0.4 release to an alternative dist-tag. ?

Scratch the alternative dist-tag part. That was wrong.