Range

rules/prefer-structured-clone.js

@@ -1,13 +1,13 @@
 'use strict';
-const {isCallExpression} = require('./ast/index.js');
+const {isCallExpression, isMethodCall} = require('./ast/index.js');
 const {} = require('./fix/index.js');
 const {isNodeMatchesNameOrPath} = require('./utils/index.js');
 
 
 const MESSAGE_ID_ERROR = 'prefer-structured-clone/error';
 const MESSAGE_ID_SUGGESTION = 'prefer-structured-clone/suggestion';
 const messages = {
-	[MESSAGE_ID_ERROR]: 'Prefer `structuredClone(…)` over `{{description}}(…)` to create a deep clone.',
+	[MESSAGE_ID_ERROR]: 'Prefer `structuredClone(…)` over `{{description}}` to create a deep clone.',
 	[MESSAGE_ID_SUGGESTION]: 'Switch to `structuredClone(…)`.',
 };
 
@@ -24,11 +24,52 @@ const create = context => {
 	};
 	const functions = [...configFunctions, ...lodashCloneDeepFunctions];
 
+// `JSON.parse(JSON.stringify(…))`
 	context.on('CallExpression', callExpression => {
+		if (!(
+			// `JSON.stringify()`
+			isMethodCall(callExpression, {
+				object: 'JSON',
+				method: 'parse',
+				argumentsLength: 1,
+				optionalCall: false,
+				optionalMember: false,
+			})
+			// `JSON.parse()`
+			&& isMethodCall(callExpression.arguments[0], {
+				object: 'JSON',
+				method: 'stringify',
+				argumentsLength: 1,
+				optionalCall: false,
+				optionalMember: false,
+			})
+		)) {
+			return;
+		}
 
+		const jsonParse = callExpression;
+		const jsonStringify = callExpression.arguments[0];
 
+		return {
+			node: jsonParse,
+			loc: {
+				start: jsonParse.loc.start,
+				end: jsonStringify.callee.loc.end,
+			},
+			messageId: MESSAGE_ID_ERROR,
+			data: {
+				description: 'JSON.parse(JSON.stringify(…))',
+			},
+			suggest: [
+				{
+					messageId: MESSAGE_ID_SUGGESTION,
+					fix(fixer) {},
+				}
+			],
+		}
 	});
 
+	// `_.cloneDeep(foo)`
 	context.on('CallExpression', callExpression => {
 		if (!isCallExpression(callExpression, {
 			argumentsLength: 1,
@@ -48,7 +89,7 @@ const create = context => {
 			node: callee,
 			messageId: MESSAGE_ID_ERROR,
 			data: {
-				description: matchedFunction.trim(),
+				description: `${matchedFunction.trim()}(…)`,
 			},
 			suggest: [
 				{

test/prefer-structured-clone.mjs

@@ -6,11 +6,13 @@ const {test} = getTester(import.meta);
 // `JSON.parse(JSON.stringify(…))`
 test.snapshot({
 	valid: [
-		'JSON.parse(JSON.stringify(foo))',
+		'JSON.parse(new JSON.stringify(foo))',
+		'new JSON.parse(JSON.stringify(foo))',
 		'JSON.parse(JSON.stringify())',
 		'JSON.parse(JSON.stringify(...foo))',
 		'JSON.parse(JSON.stringify(foo, extraArgument))',
-		'JSON.parse(JSON.stringify(foo))',
+		'JSON.parse(...JSON.stringify(foo))',
+		'JSON.parse(JSON.stringify(foo), extraArgument)',
 		'JSON.parse(JSON.stringify?.(foo))',
 		'JSON.parse(JSON?.stringify(foo))',
 		'JSON.parse?.(JSON.stringify(foo))',
@@ -20,6 +22,8 @@ test.snapshot({
 		'JSON.not_parse(JSON.stringify(foo))',
 		'not_JSON.parse(JSON.stringify(foo))',
 		'JSON.stringify(JSON.parse(foo))',
+		// Not checking
+		'JSON.parse(JSON.stringify(foo, undefined, 2))',
 	],
 	invalid: [
 		'JSON.parse(JSON.stringify(foo))',

test/snapshots/prefer-structured-clone.mjs.md

@@ -4,6 +4,51 @@ The actual snapshot is saved in `prefer-structured-clone.mjs.snap`.
 
 Generated by [AVA](https://avajs.dev).
 
+## invalid(1): JSON.parse(JSON.stringify(foo))
+
+> Input
+
+    `␊
+      1 | JSON.parse(JSON.stringify(foo))␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | JSON.parse(JSON.stringify(foo))␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer \`structuredClone(…)\` over \`JSON.parse(JSON.stringify(…))\` to create a deep clone.␊
+    `
+
+## invalid(2): JSON.parse(JSON.stringify(foo),)
+
+> Input
+
+    `␊
+      1 | JSON.parse(JSON.stringify(foo),)␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | JSON.parse(JSON.stringify(foo),)␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer \`structuredClone(…)\` over \`JSON.parse(JSON.stringify(…))\` to create a deep clone.␊
+    `
+
+## invalid(3): JSON.parse(JSON.stringify(foo,))
+
+> Input
+
+    `␊
+      1 | JSON.parse(JSON.stringify(foo,))␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | JSON.parse(JSON.stringify(foo,))␊
+        | ^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer \`structuredClone(…)\` over \`JSON.parse(JSON.stringify(…))\` to create a deep clone.␊
+    `
+
 ## invalid(1): _.cloneDeep(foo)
 
 > Input