Audit all rules for "Change Array by copy"

[fisker]

https://github.com/tc39/proposal-change-array-by-copy#overview

• Array.prototype.toReversed() -> Array
• Array.prototype.toSorted(compareFn) -> Array
• Array.prototype.toSpliced(start, deleteCount, ...items) -> Array
• Array.prototype.with(index, value) -> Array

---

• TypedArray.prototype.toReversed() -> TypedArray
• TypedArray.prototype.toSorted(compareFn) -> TypedArray
• TypedArray.prototype.with(index, value) -> TypedArray

---

• no-useless-spread no-useless-spread: Check Array#{toReversed,toSorted,toSpliced,with} #2030
• prefer-negative-index prefer-negative-index: Check .toSpliced() and .with() #2031
• prefer-set-has prefer-set-has: Support Array#{toReversed,toSorted,toSpliced,with} #2032
• prefer-spread prefer-spread: Forbid use Array#toSpliced() to copy array #2034

[fisker]

Done.

[fisker]

In prefer-spread we forbid array.slice() , array.slice(0), and array.concat() to clone array.

In theory, array.toSpliced()/array.toSpliced(0?, 0?) should be able to used to clone array.

I don't think anyone doing this for now. Let's add it if someone request.

[sindresorhus]

I don't think anyone doing this for now. Let's add it if someone request.

I think we should add it. But can be a new issue.

[fisker]

I need to confirm how toSpliced works, to confirm just array.toSpliced(), or array.toSpliced(anything) , array.toSpliced(anything, 0) should be included.

No browser support it yet. will test/read spec later.

But can be a new issue.

We can keep this open.

[fisker]

Ah, chrome 110 already supported, as tested

[1,2,3].toSpliced()
(3) [1, 2, 3]
[1,2,3].toSpliced(-1)
(2) [1, 2]
[1,2,3].toSpliced(0)
[]
[1,2,3].toSpliced(1, 0)
(3) [1, 2, 3]

I guess we should only check array.toSpliced().

[fisker]

All PR merged. Closing