Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TSD again #139

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Enable TSD again #139

merged 1 commit into from
Sep 16, 2021

Conversation

mquevill
Copy link
Contributor

Running npx tsd with 0.11.0 raises

  node_modules/electron/electron.d.ts:1657:30
  ✖  1657:30  Cannot extend an interface NodeJS.EventEmitter. Did you mean implements?  
  ✖  2994:30  Cannot extend an interface NodeJS.EventEmitter. Did you mean implements? 
  ...
  18 errors

but upgrading to 0.17.0 fixes these problems, and runs with no errors/warnings.

Not sure what the original Electron issue was that was preventing TSD running, but it seems to work properly now.

@sindresorhus sindresorhus merged commit c342211 into sindresorhus:main Sep 16, 2021
@mquevill mquevill deleted the EnableTSD branch September 16, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants