fix deepkeys to work with empty arrays and objects #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuthorProxy
force-pushed
the
fix_deepkeys_fn
branch
3 times, most recently
from
40f947c
to
9045742
Compare
sindresorhus
reviewed
Mar 5, 2023
|
CI is failing |
mmkal
approved these changes
Mar 6, 2023
AuthorProxy
force-pushed
the
fix_deepkeys_fn
branch
2 times, most recently
from
8f27bed
to
4ca581e
Compare
|
sorry, I was a little busy with other projects, now I fixed as it should be, all tests passed @sindresorhus |
AuthorProxy
force-pushed
the
fix_deepkeys_fn
branch
from
4ca581e
to
6920d3f
Compare
|
You need to update the docs. |
AuthorProxy
force-pushed
the
fix_deepkeys_fn
branch
from
6920d3f
to
53e5c63
Compare
@sindresorhus check it |
AuthorProxy
force-pushed
the
fix_deepkeys_fn
branch
2 times, most recently
from
b6c642b
to
8aee18b
Compare
readme.md
Outdated
| @@ -110,7 +110,7 @@ console.log(getProperty(object, escapedPath)); | |||
|
|
|||
| ### deepKeys(object) | |||
|
|
|||
| Returns an array of every path. Plain objects are deeply recursed and are not themselves included. | |||
| Returns an array of every path. Plain not empty objects are deeply recursed and are not themselves included. Empty objects or objects without values are included, e.g [], {}, null, undefined or NaN. | |||
There was a problem hiding this comment.
This is more confusing than it needs to be. Just say that non-empty plain objects and arrays are not themselves included.
There was a problem hiding this comment.
@sindresorhus check it
|
You also need to update index.d.ts docs. |
AuthorProxy
force-pushed
the
fix_deepkeys_fn
branch
from
8aee18b
to
170800f
Compare
AuthorProxy
force-pushed
the
fix_deepkeys_fn
branch
from
170800f
to
434c09f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #104