Cannot delete dirs containing files with invalid UTF8 sequences in their name

[silverwind]

On Linux or Windows (not macOS as it throws EILSEQ on writeFileSync), do:

mkdir test
cd test
node -p 'fs.writeFileSync(Buffer.from([0x78, 0xf6, 0x6c, 0x78]), "test")'
cd ..
node -p 'require("del").sync("test")' # fails
node -p 'fs.rmdirSync("test", {recursive: true})' # works

Error seems to come from rimraf which I think erronously attempts UTF8 decoding:

Error: ENOTEMPTY: directory not empty, rmdir '/tmp/test'
    at Object.rmdirSync (fs.js:865:3)
    at rmkidsSync (/tmp/node_modules/rimraf/rimraf.js:349:27)
    at rmdirSync (/tmp/node_modules/rimraf/rimraf.js:329:7)
    at Function.rimrafSync [as sync] (/tmp/node_modules/rimraf/rimraf.js:301:9)
    at /tmp/node_modules/del/index.js:112:11
    at Array.map (<anonymous>)
    at AsyncFunction.module.exports.sync (/tmp/node_modules/del/index.js:104:29)

[sindresorhus]

Seems more like a Node.js bug. It should consistently throw that error on all platforms, not just macOS.

[silverwind]

I suspect the EILSEQ is either an APFS limitation or a libuv bug.

[silverwind]

Regarding the deletion bug I think best course of action is to use fs.rmdir with the recursive option instead of rimraf while making sure that if a Buffer is passed, it is passed through to any fsfunction.

But to my knowledge recursive is only available on node 12.16 or higher.

[sindresorhus]

But to my knowledge recursive is only available on node 12.16 or higher.

We could check for that and at least do the right thing for those versions.

[silverwind]

I'd prefer a backport of nodejs/node#29168 to v10, thought I'd also be fine if it's only done on 12.16 or greater. I'm not sure it's possible to feature-detect the recursive option.

[silverwind]

I think it's probably better I workaround this in my module because:

• rimraf does not deal correctly with invalid UTF8 files and while it could be fixed in them, I see the chance that a PR for this would be accepted as very low.
• Fixing this would require version detection, various manual code to handle buffer paths and it would only work on Node 12.
• fs.rmdir does not support globs so using it would not get rid of dependencies.

[silverwind]

Edited above. I think the root cause may be somewhere in globby or its dependencies. To really fix it, those modules would have to avoid passing around paths as string and use Buffers exclusively because Buffer.from([0x78, 0xf6, 0x6c, 0x78]) can not be represented as an UTF-8 string.