Skip to content

Node v10 compatibility #25

Closed
Closed
@tmcw

Description

@tmcw

Hi Sindre!

The Node v10 compatibility issue in cpy leads up here, in cp-file.

The overview is:

  • Tests fail in cp-file on Node v10.0.0
  • This appears to be a result of cp-file's handling of readable streams, in that it waits a tick between when a stream becomes readable and when it starts reading from that stream
  • This results in the copy promise never resolving, and all copied files being 0 bytes

I've submitted a sketch of a PR: #24 that fixes this bug at the cost of creating directories even when the readable stream fails; would appreciate any guidance for how to achieve both goals.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions