Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tools of the Trade description #1594

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Update Tools of the Trade description #1594

merged 1 commit into from
Jul 30, 2019

Conversation

davisonio
Copy link
Contributor

...and move under Business heading.

https://github.com/cjbarber/ToolsOfTheTrade

+ move under Business heading.
@CompSciLauren
Copy link
Contributor

It looks like this list doesn't meet all the current list requirements (for example, repo name doesn't follow format "awesome-name-of-list"). I understand this list was approved under older requirements. I'm not seeing a written rule anywhere on whether current lists should remain up to date with current rules when making a PR. I imagine that would be preferred, though.

@davisonio
Copy link
Contributor Author

It looks like this list doesn't meet all the current list requirements (for example, repo name doesn't follow format "awesome-name-of-list"). I understand this list was approved under older requirements. I'm not seeing a written rule anywhere on whether current lists should remain up to date with current rules when making a PR. I imagine that would be preferred, though.

Agreed - there's a few things we need to focus on to get this up to scratch - this was approved before requirements were made better. For now, I'll update this description.

@sindresorhus sindresorhus merged commit dceb2d1 into sindresorhus:master Jul 30, 2019
@davisonio davisonio deleted the toolsoftrade-update branch August 3, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants