Add Desktop Dimmer #425
Merged
Add Desktop Dimmer #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried the app, but didn't work (macOS):
Your app is also needlessly large. Your app source itself (without Electron) is 76 MB. Pretty sure you're forgetting to exclude some development dependencies. |
|
@sindresorhus Looking forward to your opinion. Your comment regarding file size seems to be on point - a quick first analysis has shown that the reason are bundled compiler libraries. This will be addressed asap, but as it requires a rework of the developer scripts and associated build and packaging workflows, it'll be a major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Desktop Dimmer, an open-source approach for controlling desktop brightness.
Reason:
It's been out there for a while ('soft-launched') and has so far proven to be of assistance to its small developer-heavy user base. Additional exposure would improve roadmaps' feature prioritization.
Link:
https://github.com/sidneys/desktop-dimmer