Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add electron-pdf-window to Tools #389

Merged

Conversation

gerhardberger
Copy link
Contributor

By submitting this pull request, I promise I have read the contributing guidelines twice and ensured my submission follows it. I realize not doing so wastes the maintainers' time that they could have spent making the world better. 🖖

This PR adds electron-pdf-window to the tools for Electron list.

This module let's you simply add PDF viewing support to browser windows with pdf.js.

@sindresorhus
Copy link
Owner

Can you fix the merge conflict? (That does not mean opening a new PR)

@gerhardberger gerhardberger force-pushed the add-electron-pdf-window branch from 63cbaed to 84be2af Compare November 20, 2016 11:13
@gerhardberger
Copy link
Contributor Author

@sindresorhus done.

@sindresorhus sindresorhus changed the title Add electron-pdf-window to tools Add electron-pdf-window to Tools Nov 20, 2016
@sindresorhus sindresorhus merged commit beb3fce into sindresorhus:master Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants