Expanding with unused empty array values

[gerwitz]

Passing in an unused value that is an empty array causes an entertaining failure.

Expander.expand() replaces the corresponding key with an empty array:

mustermann/mustermann/lib/mustermann/ast/expander.rb

Line 95 in 3409395

values = values.each_with_object({}){ |(key, value), new_hash|

Then the mapping throws an error, which is "handled" by Expander.error_for() which attempts to sort the keys, naturally causing "ArgumentError - comparison of Symbol with Array"

[namusyaka]

@gerwitz Could you provide minimal example for reproducing the failure?

[gerwitz]

It's been a while and I hadn't discovered the :ignore flag then, but I think this is what I was talking about:

p = Mustermann.new(':one:two')
p.expand({one: 1, two: "2", three: [], four: "four"})

Note how removing the :four item from that Hash leads to a very different exception.

[namusyaka]

Thanks for the tips.
Definitely bug. I'll take a look soon.

[gerwitz]

👍 My tests get proper errors now.