[Vengeance] Per-fragment activation timing for Fracture#11057
Open
taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
Open
[Vengeance] Per-fragment activation timing for Fracture#11057taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
taherbert wants to merge 1 commit intosimulationcraft:midnightfrom
Conversation
WCL empirical data (5200+ events, 3 VDH dungeon runs) shows Fracture's fragments activate at distinct sequential times, not from the shared Gaussian used by damage-tick sources. The shared gauss<830, 80>() remains correct for Fallout, Sigil, Soul Carver, Fel Devastation, etc. Add an optional activation_delay override to spawn_soul_fragment() and soul_fragment_t. When set, get_travel_time() returns the override instead of the spec-wide Gaussian. All existing call sites (30+) are unaffected. Fracture fragment timing (observed → modeled): - MH: 641ms (was ~830ms) — gauss<641, 10> - OH: 933ms (was ~980ms) — OH delay + gauss<783, 20> - Meta 3rd: ~1000ms — unchanged (170ms spawn + Gaussian) - AT (no Meta): ~940ms (was ~830ms) — 110ms spawn delay + Gaussian - AT (Meta): ~1065ms (was ~830ms) — 235ms spawn delay + Gaussian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fragment activation timing calibrated against 5,200+ WCL events across 3 VDH dungeon runs. Fracture fragments spawn at the player, not the target, so they need their own timing instead of the shared Gaussian.
Changes
Vengeance default Gaussian
gauss<760, 120>()→gauss<830, 80>(). WCL shows ~830-864ms for damage-tick sources. Tighter cluster than previously modeled.Fracture per-fragment timing
Adds optional
activation_delaytospawn_soul_fragment()/soul_fragment_tthat bypasses the shared Gaussian inget_travel_time(). Default sentinel (timespan_t::min()) preserves existing behavior for all other call sites.Fragment spawning moves from
fracture_damage_t::impact()tofracture_t::impact().Aldrachi Tactics fragment delay
AT arrives at ~940ms (no Meta) / ~1065ms (Meta). Added Vengeance-specific spawn delay (110ms / 235ms) before the default Gaussian. Havoc/Devourer unchanged.
Timing summary
Other sources (unchanged, validated against WCL)
These all fit the shared Gaussian. No per-source overrides needed.