Skip to content

Laceration gains Unnatural Causes; in game it doesn't #11748

Description

@Nakauri

double base_ta( const action_state_t* s ) const override
{
double amount = residual_periodic_action_t::base_ta( s );
if ( affected_by.unnatural_causes.tick )
{
amount *= 1 + p()->talents.unnatural_causes->effectN( 1 ).percent();
if ( target->health_percentage() < p()->talents.unnatural_causes->effectN( 3 ).base_value() )
amount *= 1.0476;
}

this applies Unnatural Causes to Laceration, but in game it doesn't.
Minor, but worth keeping an eye on for other consistencies.

no bleed talents
https://www.warcraftlogs.com/reports/CF8RwWMd3qkLjntP?fight=last&type=damage-done&view=events&start=13910&end=20197&pins=2%24Separate%24%23244F4B%24damage%24-1%2482185048.98336049.0.Pet%240.0.0.Any%24true%240.0.0.Any%24true%2416827%7C83381%7C1%7C201754%244079%24or%24damage%24-1%240.0.0.Any%240.0.0.Any%24true%240.0.0.Any%24true%24459560
crit 22091 -> tick 324 = 0.088

Unnatural Causes
https://www.warcraftlogs.com/reports/cDHQFqt8bLWdB7CG?fight=last&type=damage-done&view=events&start=10055&end=16267&pins=2%24Separate%24%23244F4B%24damage%24-1%2482185048.98336049.0.Pet%240.0.0.Any%24true%240.0.0.Any%24true%2416827%7C83381%7C1%7C201754%244079%24or%24damage%24-1%240.0.0.Any%240.0.0.Any%24true%240.0.0.Any%24true%24459560
crit 21782 -> tick 319 = 0.088

Jagged Wounds
https://www.warcraftlogs.com/reports/PnzMLhRkfGv4wjBY?fight=last&type=damage-done&view=events&start=23582&end=29791&pins=2%24Separate%24%23244F4B%24damage%24-1%2482185048.98336049.0.Pet%240.0.0.Any%24true%240.0.0.Any%24true%2416827%7C83381%7C1%7C201754%244079%24or%24damage%24-1%240.0.0.Any%240.0.0.Any%24true%240.0.0.Any%24true%24459560
crit 21163 -> tick 342 = 0.097

both
https://www.warcraftlogs.com/reports/XG6T3Zd9AgnfkBMm?fight=last&type=damage-done&view=events&start=169052&end=175295&pins=2%24Separate%24%23244F4B%24damage%24-1%2482185048.98336049.0.Pet%240.0.0.Any%24true%240.0.0.Any%24true%2416827%7C83381%7C1%7C201754%244079%24or%24damage%24-1%240.0.0.Any%240.0.0.Any%24true%240.0.0.Any%24true%24459560
crit 23010 -> tick 371 = 0.097

adding something like this at this line would match, like the Wildfire Bomb exception at 7229:
5174 // laceration_t( hunter_t* p ) : residual_bleed_base_t( "laceration", p, p->talents.laceration_bleed ) { affected_by.unnatural_causes.tick = as<uint8_t>( 0 ); }

(also might be a good time to re-investigate the wildfire exception)

// 2026-02-11: Wildfire Bomb's direct damage is not buffed by Unnatural Causes in game, despite being in spell data
affected_by.unnatural_causes.direct = as<uint8_t>( 0 );

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions